Bluetooth: Controller: Fix DLE HCI params parsing #45971
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: API
sjanc
force-pushed
the
dle_hci_param
branch
2 times, most recently
from
dfe1cfa to
9e183a5
Compare
|
fixes #44164 |
4 tasks
sjanc
requested review from
carlescufi,
cvinayak,
kruithofa,
ppryga-nordic and
thoh-ot
as code owners
sjanc
force-pushed
the
dle_hci_param
branch
3 times, most recently
from
e571495 to
bac8467
Compare
Member
|
@cvinayak please review |
cvinayak
reviewed
Jul 11, 2022
Contributor
cvinayak
left a comment
cvinayak
left a comment
There was a problem hiding this comment.
Changes look good and do not affect the conformance tests (HCI tests pass). The CI failure needs addressing though.
zephyrbot
requested review from
Thalley,
asbjornsabo,
hermabe and
jori-nordic
LE Write Suggested Default Data Length and LE Set Data Length commands are suggestions from host and should be validated only as per HCI specification regarding internal setting of LLCP. LLCP is allowed to use other values if needed. Signed-off-by: Szymon Janc <[email protected]>
Some tests assume that if IUT accepted HCI_LE_Set_Data_Length command than HCI_LE_Data_Length_Change event will always be sent. This is not the case anymore as HCI_LE_Data_Length_Change is sent only if effective parameters changed. Those tests should be re-enabled when EDDT implementation is updated. Signed-off-by: Szymon Janc <[email protected]>
kruithofa
approved these changes
Sep 5, 2022
Contributor
|
No objections from me. If this is passing latest TCRL based conformance tests, you have my approval. @thoh-ot Please get a review at your side. |
erbr-ot
approved these changes
Sep 15, 2022
Contributor
erbr-ot
left a comment
erbr-ot
left a comment
There was a problem hiding this comment.
LGTM - did an EBQ run (HCI and CON tests) with this commit on Oticon target with no added failures.
cvinayak
approved these changes
Sep 22, 2022
Member
|
Should this go for 3.2.0? The matching issue is tagged as Enhancement... tagging for 3.3.0, feel free to move it as necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LE Write Suggested Default Data Length and LE Set Data Length commands
are suggestions from host and should be validated only as per HCI
specification regarding internal setting of LLCP.
LLCP is allowed to use other values is needed.
fixes #44164
Signed-off-by: Szymon Janc [email protected]